Web crawling 7th PR #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YLee2121
requested changes
Aug 14, 2023
There was a problem hiding this comment.
This is what I've done in #18. You should merge the main to your branch first and solve the merge conflict. In this case, you remove what I've done in #18.
Please check the #18 again and adjust your code.
Also read the PR report again.
Moreover, the order of your get function return is:
link, articles
Rather than
article, link
|
Thanks for the correction, I've just fixed it. Please take a look.
…On Mon, Aug 14, 2023 at 7:24 PM YLee2121 ***@***.***> wrote:
***@***.**** requested changes on this pull request.
This is what I've done in #18 <#18>.
You should merge the main to your branch first and solve the merge
conflict. In this case, you remove what I've done in #18
<#18>.
Please check the #18 <#18> again
and adjust your code.
Moreover, the order of your get function return is:
link, articles
Rather than
article, link
—
Reply to this email directly, view it on GitHub
<#20 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4IP7NBXBEKQMYNTXR5OMZTXVKXTXANCNFSM6AAAAAA3PFD2PQ>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👉 Summary
Main in Crawl.py can return links to the articles now.