Get Summary API for Frontend User #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YLee2121
commented
Aug 12, 2023
| link_list = [] | ||
| summary_list = [] | ||
|
|
||
| link_list, raw_article_list = Crawler.main(ticker) |
There was a problem hiding this comment.
Crawler.main() should also return the link. You need to adjust your code in Crawler.py
YLee2121
commented
Aug 12, 2023
| openai.api_key = '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' | ||
|
|
||
| #article_texts = Crawler.main() | ||
| def main(article_texts): |
There was a problem hiding this comment.
This function should input the articles and return the summaries.
No action is needed at this PR, just notify you simply.
YLee2121
force-pushed
the
kyle/integrateBackend
branch
from
affc288
to
3387c02
Compare
YLee2121
force-pushed
the
kyle/integrateBackend
branch
from
3387c02
to
6c230ae
Compare
alex308248
approved these changes
Aug 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get Summary API
Summary
Input a ticker name from the front, the API will provide five article links and the corresponding five summaries.
Refactor
Crawler.pyand also revise the return variable, adding link as return.Attention
@tejkoiejgns ModelAPI.main()
ModelAPI.main()should take an input, the article texts. Check the code and you will see what I mean.@Weirdojord Crawler.main()
Crawler.main()should also return the corresponding five links. Each of your get_article sub-function has a returnlinks, but in themain(), it doesn't return the links. I wanted you to organize the Crawler.py script to satisfy the needs of the API in this PR.