Multiple Fixes #11
Merged
Multiple Fixes #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolves security flaw by moving serverside code to a serverside only file so the client can't access the api key. - Moved configuration to a local table so the values wont be accidentally overwritten by another addon - Made netmessage name more unique so there's less likely to be a conflict
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
Resolves security flaw by moving server side code to a serverside only file so the client can't access the API key
Moved configuration to a local table so the values won't be accidentally overwritten by another addon
Made netmessage name more unique so there's less likely to be a conflict