This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that timestamps did not include milliseconds when retrieved from the db. I looked at changing the
TIMESTAMP_FORMAT
, but this method will receive two formats one with millisecondsyyyy-MM-dd HH:mm:ss.SSS
and other times with microsecondsyyyy-MM-dd HH:mm:ss.SSSSSS
. ThestringToTimeStamp
falls back to seconds if the date isn't specific. I talked to Doug, and this was added in 2012 when I don't think there was a parser for this type inpg-types
, which was part ofpg
at the time. It has since been added, so removing this uses the default parser inpg-types
](https://github.com/brianc/node-pg-types/blob/f320a111e242716dde68f619fdef44969803f039/lib/textParsers.js#L166).Going to run this against the c2fo tests to make sure everything passes.