Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PID M-codes #86

Open
IhorNehrutsa opened this issue Aug 3, 2021 · 3 comments
Open

PID M-codes #86

IhorNehrutsa opened this issue Aug 3, 2021 · 3 comments
Labels
question Further information is requested

Comments

@IhorNehrutsa
Copy link

IhorNehrutsa commented Aug 3, 2021

Intellistep GM-codes do not match any of the found variants

https://reprap.org/wiki/G-code
M130: Set PID P value
M131: Set PID I value
M132: Set PID D value
M132 in MakerBot
M133: Set PID I limit value
M134: Write PID values to EEPROM
M135: Set PID sample interval
M136: Print PID settings to host

https://marlinfw.org/docs/gcode/M304.html
M303 - PID autotune
M304 - Set Bed PID

@CAP1Sup CAP1Sup added the question Further information is requested label Aug 3, 2021
@CAP1Sup
Copy link
Owner

CAP1Sup commented Aug 3, 2021

I picked out codes for commands not found in Marlin. If you want to change them to more established commands, I think that would be best. Open a PR, it shouldn't be too hard to modify the parser for whatever commands and parameters you would like. The parser is very flexible and easy to work with

CAP1Sup added a commit that referenced this issue Sep 2, 2021
MInor adjustement to some PID commands. In response to #86
@CAP1Sup
Copy link
Owner

CAP1Sup commented Sep 2, 2021

This should be complete now. I used the more universal M301 instead of M130s

@CAP1Sup
Copy link
Owner

CAP1Sup commented Sep 3, 2021

@IhorNehrutsa have you had a chance to test out the commands?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants