Thchang/2121 matching generated moment images toggle #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TienHao do you think it is possible to beautify the UI like the following? This would save some space.
|
|
@kswang1029 Sure, just changed like this. |
kswang1029
approved these changes
Aug 3, 2023
crocka
approved these changes
Aug 14, 2023
YuHsuan-Hwang
approved these changes
Aug 15, 2023
YuHsuan-Hwang
deleted the
thchang/2121_matching_generated_moment_images_toggle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2121.
Added a toggle in the moment generator to control the generated moment image(s) to be matched to the spatial reference image.
The toggle only shows up when the data source image is the spatial reference image.
The controlling property
momentToMatchwas added to AppStore.Checklist
For linked issues (if there are):
For the pull request:
e2e test passing/ corresponding fix addedno changelog update neededprotobuf updated to the latest dev commit/ no protobuf update neededBackendServiceunchanged /BackendServicechanged and corresponding ICD test fix added