Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematodes integration #39

Merged
merged 8 commits into from
May 30, 2023
Merged

Schematodes integration #39

merged 8 commits into from
May 30, 2023

Conversation

jcrozum
Copy link
Collaborator

@jcrozum jcrozum commented May 19, 2023

No description provided.

@jcrozum
Copy link
Collaborator Author

jcrozum commented May 19, 2023

I just made a small commit to improve efficiency when using the newest version of schematodes. The tests failed because the new schematodes is still being uploaded to pypi. I'll rerun when the upload is complete and we should pass the tests.

Edit: this is done, and now we pass the tests. We will require schematodes v0.3.0 or higher going forward

Copy link
Collaborator

@austin-marcus austin-marcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The only thing is the last couple commits here seem to require schematodes 0.3.0. I suppose we should specify which version is required somewhere.

@jcrozum jcrozum merged commit 9b76b73 into master May 30, 2023
4 checks passed
@jcrozum jcrozum deleted the schematodes-integration branch January 5, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants