Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pylint fixes for build.py #1416

Merged
merged 1 commit into from Feb 6, 2021
Merged

Pylint fixes for build.py #1416

merged 1 commit into from Feb 6, 2021

Conversation

Killswitch00
Copy link
Contributor

When merged this pull request will:

  • Fix issues found by pylint in tools/build.py

jonpas
jonpas reviewed Feb 6, 2021
View reviewed changes
tools/build.py Outdated Show resolved Hide resolved
@jonpas jonpas added this to the Ongoing milestone Feb 6, 2021
jonpas
jonpas approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please don't force push, it is impossible to see what was changed after reviews.

@Killswitch00
Copy link
Contributor Author

My GitHub-foo is a bit rusty. I won't force push again. Thanks for the review!

@Killswitch00 Killswitch00 merged commit e3b92c2 into master Feb 6, 2021
@Killswitch00 Killswitch00 deleted the build-pylint-fixes branch February 6, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
Enhancement Ignore Changelog Tools
Projects
None yet
Milestone
Ongoing
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Killswitch00 @jonpas