Disposable - Replace magazines in backpack when launcher fits backpacks #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10Dozen
changed the title
commy2
suggested changes
Jul 27, 2021
There was a problem hiding this comment.
- No need to make a config entry for this, because it already is one with the "WeaponsSlotsInfo\allowedSlots" array.
- No need to maintain a list when we can abuse HashMaps as sets. Lookup in list is O(n) at worts, while lookup in set is O(1).
Disclaimer, suggestions not tested, so there may be typos or logic holes.
|
|
Such is life. |
|
lgtm Did you test if it works? |
Yeah, works fine. |
10Dozen
changed the title
commy2
approved these changes
Jul 27, 2021
I don't know. It seems not really necessary. |
commy2
reviewed
Jul 27, 2021
Co-authored-by: commy2 <commy-2@gmx.de>
|
Good job :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
launcher_loaded >> WeaponSlotsInfo >> allowedSlotsarray, implements Allow Disposable Launchers to be replaced in Backpacks #1356)