Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings - Add Addon Searchbar #1606

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Sep 20, 2023

When merged this pull request will:

  • Add a search bar to the addon options menu: allows searching for addons, works off display name. Simple regex matching.

Code style is inconsistent but only to the point of what was already there. The odd offsets on control positions are a result of my OCD trying to get everything aligned properly.

107410_20230920044326_1

I'd like to make a search bar for settings themselves but that'll have to be another PR. Don't get me wrong, I love the framework, but trying to change anything is hell.

Keybinds:

  • CTRL-F to focus search bar.
  • Enter to search. Blocks display closing if search bar is selected.

@LinkIsGrim LinkIsGrim changed the title WIP - Settings - Add Searchbars WIP - Settings - Add Addon Searchbar Sep 20, 2023
@LinkIsGrim LinkIsGrim marked this pull request as ready for review September 20, 2023 08:44
@LinkIsGrim LinkIsGrim changed the title WIP - Settings - Add Addon Searchbar Settings - Add Addon Searchbar Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant