Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the CBA keybinding list in the briefing. Fixes #44 #78

Merged
merged 6 commits into from
Jun 21, 2015

Conversation

Killswitch00
Copy link
Contributor

This will display all key binds that use the CBA key binding system in the briefing, under the CBA->Keybindings diary record section.

@ViperMaul
Copy link
Contributor

Looks like a great start.
Currently it is hard to differentiate between the keybinds and the feature.
http://gyazo.com/9abde0f5f090f029996bc9949e34536f

Perhaps we can give the keybinds some color. Or some kind of contrasting solution.

@ViperMaul
Copy link
Contributor

The different colors look great!

Two opportunities for improvement.

  1. Keybind Combo Display
    When you scan the keybinds fast and most people do, it is the spaces that normally separates a key combo. And dashes and pluses that combines a single key combo.
    So Left Shift-Left Alt-+ [NUM] looks like 4 keys instead 3 keys.
  2. The correct key is + key but, which plus key, well the NUM-+ key. However since the + is displayed before the [NUM] it loses that meaning.
    Look at this

Compared to this

One thought would be to just

  1. Abbreviate the Left and Right with no space in between.
    so Left Shift would be come LShift and Right Shift would become RShift. Now it looks like one key instead of two separate keys at a quick glance.
  2. Same with NUM pad handling it should be shown as Num+ or [Num+] as this is closer to the defacto standard way of representing this key.
  3. Remove the dash as the key separator and just since we employed the above. However keys like Caps Lock will still look like two keys even though most players will understand it is one key. Example: LAlt Caps Lock
  4. We could experiment what it looks like to enclose each key inside { }
    Example: { LAlt }{ Caps Lock }
    or
    Example { RShift }{ [ } or would that be { RShift }{ LBracket }

We have some experimenting to do.

@Killswitch00
Copy link
Contributor Author

Let's try dba7707 on for size and see how that style feels.

@ViperMaul ViperMaul added this to the CBA_A3 v2.0 milestone Jun 20, 2015
@ViperMaul
Copy link
Contributor

Looks much improved.
The next thought to mind is the LAlt LShift etc looks wordy and redundant.
I think it would now look cleaner if we Omit the L for all left SHIFT, CTRL, ALT keys. But continue to use the rare RShift, RCTRL, RAlt

Reference:

@ViperMaul
Copy link
Contributor

Looks much cleaner.
image

@ViperMaul
Copy link
Contributor

👍

ViperMaul added a commit that referenced this pull request Jun 21, 2015
Restore the CBA keybinding list in the briefing. Fixes #44
@ViperMaul ViperMaul merged commit d70a74c into master Jun 21, 2015
@ViperMaul ViperMaul deleted the KeybindingsListInBriefing44 branch June 21, 2015 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants