remove obsolete ui_helper component #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we do drop a PBO, we need to be very clear in the next update that people need to delete or there will be old pbo key problems |
|
Steam does delete it correctly, or not? |
|
I think so |
|
Then a warning with the changelog / release notes should be good. |
jonpas
reviewed
Dec 7, 2017
| @@ -11,6 +11,9 @@ class CfgPatches { | |||
| version = VERSION; | |||
| authors[] = {"Dr Eyeball", "commy2"}; | |||
| }; | |||
|
|
|||
| // Backwards compatibility | |||
| class cba_ui_helper: ADDON {author = "";}; | |||
There was a problem hiding this comment.
Why not just inherit author? It's set to CBA anyways.
There was a problem hiding this comment.
This prevents the credits line stuff from the help component to show up this removed component from time to time. Same is done for other bwc CfgPatches entries like the four aliases of XEH.
There was a problem hiding this comment.
Oh I see, time to do that in ACRE... :P
Thanks!
jonpas
approved these changes
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
This component was meant for TKOH to work around some kind of initialization problem. Since CBA_A3 is not compatible with TKOH, this can be removed.
Otherwise it's used by the fleximenu to #include the dik codes. That's not needed either, because they can just be included directly.