TrainingModule parameter changes #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sarthakpati Did our github permissions change? I can't seem to request reviewers anymore. UI bug, maybe? |
Try now? |
OK, that worked. Thanks! |
|
Hey @AlexanderGetka-cbica @Getkablue: if you are still working on this, could convert to draft? Thanks! |
|
This is actually done for now, I just forgot to commit my last change. This can be reviewed. |
ashishsingh18
approved these changes
Nov 10, 2020
sarthakpati
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some changes to the GUI and CLI of training module and a few changes to the back-end to just make it work while the bigger changes are pending.
This does not include the (sweeping) structural changes to the TrainingModule.cpp back-end -- this PR mostly introduces the Parameter Object pattern so as to more easily plumb data through (also, C and G optimization options are now tunable).
Those big refactors on the back-end side will come later as a PR, before the addition of the new feature selection approaches. That way, the structural changes with the existing modes will come first, then the additions as a separate PR to make it easier to review.