Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing migration from i18n setup #66

Merged
merged 1 commit into from
Jul 23, 2018
Merged

Add missing migration from i18n setup #66

merged 1 commit into from
Jul 23, 2018

Conversation

jraddaoui
Copy link
Collaborator

Connects to #16.

@jraddaoui jraddaoui self-assigned this Jul 21, 2018
@jraddaoui jraddaoui requested a review from sevein July 21, 2018 19:30
@codecov
Copy link

codecov bot commented Jul 21, 2018 •
edited

Codecov Report

Merging #66 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage    88.7%   88.75%   +0.04%     
==========================================
  Files          38       39       +1     
  Lines        1434     1440       +6     
==========================================
+ Hits         1272     1278       +6     
  Misses        162      162
Impacted Files Coverage Δ
...cesspoc/dips/migrations/0009_auto_20180721_1926.py 100% <100%> (ø)

@jraddaoui
Copy link
Collaborator Author

jraddaoui commented Jul 21, 2018 •
edited

Hi @sevein, looks like the verbose_name changes in the model fields from #58 require a migration.

@jraddaoui jraddaoui added this to the beta milestone Jul 21, 2018
sevein
sevein approved these changes Jul 23, 2018
View reviewed changes
Copy link
Collaborator

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You should use https://github.com/artefactual/archivematica-storage-service/blob/31bad497be0ce1c94f3bf3413a93b75bae9815e3/.travis.yml#L36-L37.

@jraddaoui jraddaoui mentioned this pull request Jul 23, 2018
Closed
@jraddaoui jraddaoui merged commit 8a73008 into master Jul 23, 2018
@jraddaoui jraddaoui deleted the dev/missing-migration branch July 23, 2018 16:16
@sallain sallain added this to Done in SCOPE Mar 26, 2019
@sallain sallain removed this from Done in SCOPE Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevein sevein sevein approved these changes

Assignees

@jraddaoui jraddaoui

Labels
None yet
Projects
None yet
Milestone
beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jraddaoui @sevein