[FEATURE] displaying possible teletext pages without actual extraction #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Your PR breaks these cases:
Check the result page for more info. |
|
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Your PR breaks these cases:
Check the result page for more info. |
anshul1912
requested changes
Dec 22, 2018
src/lib_ccx/general_loop.c
Outdated
| @@ -677,6 +677,10 @@ int process_data(struct encoder_ctx *enc_ctx, struct lib_cc_decode *dec_ctx, str | |||
| if (ret == CCX_EINVAL) | |||
| return ret; | |||
| } | |||
| else { | |||
There was a problem hiding this comment.
generally in code, if you check else statement is written like
if(condition)
{
//statement
}
else
{
\\statement
}
we do not do use K&R coding style in this file
if (condition) {
//statement
} else {
//statement
}
| @@ -907,13 +907,13 @@ void process_telx_packet(struct TeletextCtx *ctx, data_unit_t data_unit_id, tele | |||
| if (!ctx->seen_sub_page[thisp]) | |||
| { | |||
| ctx->seen_sub_page[thisp]=1; | |||
| mprint ("\rNotice: Teletext page with possible subtitles detected: %03d\n",thisp); | |||
| printf ("\rNotice: Teletext page with possible subtitles detected: %03d\n",thisp); | |||
There was a problem hiding this comment.
printf are really NO, I would suggest use dbg_print (CCX_DMT_TELETEXT,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
According to #1034 added ability to print possible teletext pages in -out=report mode.