New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] displaying possible teletext pages without actual extraction #1058

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@navimakarov
Copy link
Contributor

navimakarov commented Dec 19, 2018

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

According to #1034 added ability to print possible teletext pages in -out=report mode.

navimakarov added some commits Dec 19, 2018

@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Dec 19, 2018

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 84/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Dec 19, 2018

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 2/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 34/34
CEA-708 5/14
DVD 3/3
Options 0/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@@ -677,6 +677,10 @@ int process_data(struct encoder_ctx *enc_ctx, struct lib_cc_decode *dec_ctx, str
if (ret == CCX_EINVAL)
return ret;
}
else {

This comment has been minimized.

@anshul1912

anshul1912 Dec 22, 2018

Contributor

generally in code, if you check else statement is written like

if(condition)
{
    //statement
}
else
{
    \\statement
}

we do not do use K&R coding style in this file

if (condition) {
    //statement
} else {
    //statement
}
@@ -907,13 +907,13 @@ void process_telx_packet(struct TeletextCtx *ctx, data_unit_t data_unit_id, tele
if (!ctx->seen_sub_page[thisp])
{
ctx->seen_sub_page[thisp]=1;
mprint ("\rNotice: Teletext page with possible subtitles detected: %03d\n",thisp);
printf ("\rNotice: Teletext page with possible subtitles detected: %03d\n",thisp);

This comment has been minimized.

@anshul1912

anshul1912 Dec 22, 2018

Contributor

printf are really NO, I would suggest use dbg_print (CCX_DMT_TELETEXT,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment