New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] for issue #668 (Windows and Multicast) #1059

Merged
merged 3 commits into from Dec 26, 2018

Conversation

Projects
None yet
4 participants
@ShouryaAggarwal
Copy link
Contributor

ShouryaAggarwal commented Dec 21, 2018

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

So I read that in windows we need to bind to INADDR_ANY only while joining the multicast group, so I left it at that only. Now while receiving the stream from udp multicast, I peak at the header file and match the source ip with the provided ip and only continue if the IPs match. I have tested it on windows using ffmpeg stream system. Let me know if any more changes need to be done.

@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Dec 21, 2018

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 84/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Dec 21, 2018

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 4/7
DVR-MS 2/2
General 26/27
Hauppage 3/3
MP4 2/3
NoCC 3/10
Teletext 0/21
WTV 0/13
XDS 0/34
CEA-708 0/14
DVD 0/3
Options 0/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
Show resolved Hide resolved src/lib_ccx/file_functions.c Outdated
Show resolved Hide resolved src/lib_ccx/file_functions.c Outdated

ShouryaAggarwal and others added some commits Dec 22, 2018

@cfsmp3 cfsmp3 merged commit 6209c63 into CCExtractor:master Dec 26, 2018

1 of 3 checks passed

CI - linux Not all tests completed successfully, please check
Details
CI - windows Not all tests completed successfully, please check
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment