New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Travis build for macOS. Also add cmake build test. #1063

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@saurabhshri
Copy link
Member

saurabhshri commented Jan 10, 2019

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • [ ] I have mentioned this change in the [changelog]

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

  • Fixed failing Travis build for macOS. Also added cmake build test in the same.
  • Removed linux build tests because Sample Platform already covers it.
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Jan 10, 2019

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 5/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 84/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
@ccextractor-bot

This comment has been minimized.

Copy link
Collaborator

ccextractor-bot commented Jan 10, 2019

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 85/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.
- os: osx
osx_image: xcode10.1
compiler: clang
addons:

This comment has been minimized.

@canihavesomecoffee

canihavesomecoffee Jan 11, 2019

Member

It looks like you have a lot of whitespace after the end of line... Care to correct? :)

This comment has been minimized.

@saurabhshri

saurabhshri Jan 12, 2019

Member

Hi! I would love to correct it, but am unable to locate the extra whitespaces. How do I fix it?

screenshot 2019-01-12 at 7 38 02 pm

This comment has been minimized.

@canihavesomecoffee

canihavesomecoffee Jan 12, 2019

Member

There's none -_-

It's because the line on the left side is wrapping over multiple ones that this side is as well... My bad.

This comment has been minimized.

@saurabhshri

saurabhshri Jan 12, 2019

Member

Ah, let me know if any changes are needed 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment