return a non-zero return code if no subtitles were found

[ghost]

Previous PR: #535

[cfsmp3]

Could work. @canihavesomecoffee what does the CI say?
@anukul I can't see a pending code-in task, did you claim and submit?

[ghost]

Yes, you had approved it tentatively. It is awaiting parental consent approval for completion.

[canihavesomecoffee]

The PR is almost fine.

@anukul:

Test 28-30 is incorrectly returning status code 10, while the output is non-empty. They're all 3 .mov files.
Test 139 should be returning 10, but seemingly returns 0.

[ghost]

Test 139 looks fine to me.

➜  fix ./ccextractor inp.mpg
CCExtractor 0.83, Carlos Fernandez Sanz, Volker Quetschke.
Teletext portions taken from Petr Kutalek's telxcc
--------------------------------------------------------------------------
Input: inp.mpg
[Extract: 1] [Stream mode: Autodetect]
[Program : Auto ] [Hauppage mode: No] [Use MythTV code: Auto]
[Timing mode: Auto] [Debug: No] [Buffer input: No]
[Use pic_order_cnt_lsb for H.264: No] [Print CC decoder traces: No]
[Target format: .srt] [Encoding: UTF-8] [Delay: 0] [Trim lines: No]
[Add font color data: Yes] [Add font typesetting: Yes]
[Convert case: No] [Video-edit join: No]
[Extraction start time: not set (from start)]
[Extraction end time: not set (to end)]
[Live stream: No] [Clock frequency: 90000]
[Teletext page: Autodetect]
[Start credits text: None]

-----------------------------------------------------------------
Opening file: inp.mpg
File seems to be a transport stream, enabling TS mode
Analyzing data in general mode
Creating inp.srt


New video information found
[1920 * 1080] [AR: 03 - 16:9] [FR: 04 - 29.97] [progressive: no]

100%  |  00:19
Number of NAL_type_7: 0
Number of VCL_HRD: 0
Number of NAL HRD: 0
Number of jump-in-frames: 0
Number of num_unexpected_sei_length: 0

Total frames time:	  00:00:20:020  (600 frames at 29.97fps)

Min PTS:				00:00:00:400
Max PTS:				00:00:20:453
Length:				 00:00:20:053

Initial GOP time:	   00:00:00:000
Final GOP time:		 00:00:19:500+15F
Diff. GOP length:	   00:00:19:500+15F	(00:00:20:000)


Total user data fields: 600
HDTV type user data fields: 600
Done, processing time = 1 seconds
This is beta software. Report issues to carlos at ccextractor org...
➜  fix wc -l inp.srt 
15 inp.srt
➜  fix 

As for tests 28-30, I don't think I'll be able to download those files with my current internet connection.

I'll change to another ISP by 28th December and try to fix those.

[ghost]

Okay, I checked 28 and my workaround for mp4 is incorrect. I had assumed that ctx->freport.mp4_cc_track_cnt would store a non zero value in the case when captions are present. But I guess it's not so.

[cfsmp3]

No, that doesn't help. You can have a CC track but no subtitles inside of it but any reason, for example. Only way is delay opening the output file until the first write.

…

On Wed, Dec 28, 2016 at 6:39 PM, Anukul Sangwan ***@***.***> wrote: Okay, my workaround for mp4 is incorrect. I had assumed that ctx->freport.mp4_cc_track_cnt would store a non zero value in the case when captions are present. But I guess it's not so. Should I modify the gpacmp4 libary? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#553 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFrJ2QALwjLfRB_WE53GnpobaPJzu57oks5rMp7EgaJpZM4LQDYS> .

[ghost]

The last commit fixes Tests 28, 29, 30.
I'm not completely convinced as to why Test 139 should be returning 10, it does generate a non-empty subtitle file.

[ghost]

@cfsmp3 @canihavesomecoffee

[anshul1912]

why tmp variable needed, why cant you just capture the return value in ret variable

[ghost]

because of this.