Improve SBS #651
Merged
Improve SBS #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nit_encoder_context * more debug for SBS
* Use own SBS-context structure to store SBS-data (fix CCExtractor#639) * Search for BEST match of new string and SBS-buffer (instead of first appropriate..) * all tests are fixed and passed
This version returns enough readable subs , splitted into sentences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
encoder_context, SBS uses its own buffers and structuresThe code is still dirty, but it already works good enough
Important notice
SBS is color-blind, so
<font>tags cause errors in resulting output (</font>will be placed in next sub). Please, runccextractor -sbsonly with-nodvbcolor