Allow choosing between geometry_msgs/Twist and #22
Conversation
geometry_msgs/TwistStamped (issue CCNYRoboticsLab#21)
| // **** Are velocity input messages stamped? | ||
| // if false, will subscribe to Twist msgs on /vel | ||
| // if true, will subscribe to TwistStamped msgs on /vel | ||
| if (!nh_private_.getParam ("stamped_vel", stamped_vel_)) |
There was a problem hiding this comment.
Where do we tell the Parameter Server that stamped_vel_ parameter is true?
There was a problem hiding this comment.
I added a parameter in my launch file. As by default it expects stamped Twist messages, nobody will notice the change unless adding stamped_vel as true in the launch file
There was a problem hiding this comment.
Ok, so the launch file is what the users of this package makes by themselves, right? If that's the case, this needs documented somewhere (maybe adding to README or equivalent?) otherwise no one notices this feature even if this feature might be valuable to them.
There was a problem hiding this comment.
I added a parameter in demo.launch to raise awareness of how to activate the proposed feature. https://github.com/ccny-ros-pkg/scan_tools/pull/35/files#diff-da85c9e3d31b840300d30555c2129fc8R6
|
travis config is now added. Triggering it by reopening. |
|
I re-opened this in #35 to adjust to the current default branch, as well as utilize travis. Thanks! |
geometry_msgs/TwistStamped (issue #21)