Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Travis for config validation #73

Closed
robbiet480 opened this issue Feb 21, 2017 · 10 comments
Closed

Implement Travis for config validation #73

robbiet480 opened this issue Feb 21, 2017 · 10 comments

Comments

@robbiet480
Copy link

@tradiuz recently got Travis CI working to validate configuration upon pushing to GitHub. It's quite simple, just sign up for a free Travis-CI.org account and follow these instructions.

You have the most popular maintained configuration in the home-assistant-config topic on GitHub now so I think i'm going to "require" (quotes because it would be appreciated if you could implement) this one for you since we are going to start announcing this as best practice for public configs.

@tradiuz
Copy link

tradiuz commented Feb 21, 2017

If you need any assistance, I'll gladly help out, since I found it hugely helpful.

@Chariyski
Copy link

What is the status of your build?
Mine failed :( - https://travis-ci.org/Chariyski/Home-Assistant-Configuration/builds/203940571

@robbiet480
Copy link
Author

@Chariyski Looks like you have a secret that should have been an integer but is actually a string.

CCOSTAN pushed a commit that referenced this issue Feb 21, 2017
@robbiet480
Copy link
Author

@Chariyski Actually other way around, you may have provided an int when it was expecting a string

CCOSTAN pushed a commit that referenced this issue Feb 21, 2017
@CCOSTAN
Copy link
Owner

CCOSTAN commented Feb 21, 2017

@Chariyski - All Good now!
image

Thanks for the suggestion and help everyone.

@Chariyski
Copy link

Thanks from me, too.

Mine is green, too 👍

@brianjking
Copy link

I want to add-in a webhook to git pull whenever new commits are pushed to my repo and the Travis-CI build reports back a successful build with The command "hass -c . --script check_config" exited with 0. After that I'd want to run sudo systemctl restart home-assistant.service

Any tips? BTW - Here's my repo: https://github.com/brianjking/hass-config

@CCOSTAN
Copy link
Owner

CCOSTAN commented Feb 23, 2017

None from me @brianjking. I pretty much only PUSH up to github. I have never had to do a pull. I'm work from Home so I pretty much only code when I am next to the Pi.

Side note: Do you love your 3d printer? I think I want one now.

@robbiet480
Copy link
Author

@brianjking you'd want to watch for the status webhook that GitHub will send you once Travis updates the status. Here's the GitHub docs on that.

@brianjking
Copy link

@CCOSTAN My Pi is headless with the occasional use of a VNC connection. I do my editing from either my Mac, Linux or Windows machine, push to GitHub, GitHub webhooks to Travis-CI, if Travis-CI says all is well then I'll ssh to the Pi and git pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants