Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed port for ext_1 and ext_2 to Boolean from String #45

Merged
merged 2 commits into from
May 13, 2015

Conversation

vvpalav
Copy link
Contributor

@vvpalav vvpalav commented May 11, 2015

Please review for CDAT/cdat#1306

('ext_1', 'basic:String', True),
('ext_2', 'basic:String', True),
('ext_1', 'basic:Boolean', True),
('ext_2', 'basic:Boolean', True),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum... not that it matters really but isolines do NOT have ext_1 and ext_2... Not sure why this bit is here

@doutriaux1
Copy link
Contributor

will test soon.

@doutriaux1
Copy link
Contributor

@vvpalav plot a boxfill, click edit, set extensions to "yes" click apply

Traceback (most recent call last):
  File "/lustre/atlas2/csc121/world-shared/uvcdat/2015-05-06/vistrails/vistrails/gui/uvcdat/plot.py", line 78, in configureDone
    action)
  File "/lustre/atlas2/csc121/world-shared/uvcdat/2015-05-06/vistrails/vistrails/gui/uvcdat/project_controller.py", line 1065, in plot_properties_were_changed
    self.update_plot_configure(sheetName, row, col)
  File "/lustre/atlas2/csc121/world-shared/uvcdat/2015-05-06/vistrails/vistrails/gui/uvcdat/project_controller.py", line 849, in update_plot_configure
    widget = self.get_plot_configuration(sheetName,row,col)
  File "/lustre/atlas2/csc121/world-shared/uvcdat/2015-05-06/vistrails/vistrails/gui/uvcdat/project_controller.py", line 907, in get_plot_configuration
    cell.plots)
  File "/lustre/atlas2/csc121/world-shared/uvcdat/2015-05-06/vistrails/vistrails/packages/uvcdat_cdms/pipeline_helper.py", line 76, in show_configuration_widget
    return CDMSPlotWidget(controller,version,plots,vars)
  File "/lustre/atlas2/csc121/world-shared/uvcdat/2015-05-06/vistrails/vistrails/packages/uvcdat_cdms/pipeline_helper.py", line 1112, in __init__
    self.create_plot_widget()
  File "/lustre/atlas2/csc121/world-shared/uvcdat/2015-05-06/vistrails/vistrails/packages/uvcdat_cdms/pipeline_helper.py", line 1237, in create_plot_widget
    stacked_widget = self.create_conf_widgets()
  File "/lustre/atlas2/csc121/world-shared/uvcdat/2015-05-06/vistrails/vistrails/packages/uvcdat_cdms/pipeline_helper.py", line 1278, in create_conf_widgets
    self.add_conf_widget(plot_module)
  File "/lustre/atlas2/csc121/world-shared/uvcdat/2015-05-06/vistrails/vistrails/packages/uvcdat_cdms/pipeline_helper.py", line 1285, in add_conf_widget
    show_buttons=False)
  File "/lustre/atlas2/csc121/world-shared/uvcdat/2015-05-06/vistrails/vistrails/packages/uvcdat_cdms/widgets.py", line 32, in __init__
    self.mapAttributesToFunctions()
  File "/lustre/atlas2/csc121/world-shared/uvcdat/2015-05-06/vistrails/vistrails/packages/uvcdat_cdms/widgets.py", line 156, in mapAttributesToFunctions
    self.attributes[fun] = self.getValueFromFunction(fun)
  File "/lustre/atlas2/csc121/world-shared/uvcdat/2015-05-06/vistrails/vistrails/packages/uvcdat_cdms/widgets.py", line 137, in getValueFromFunction
    value = ast.literal_eval(f.params[0].strValue)
  File "/lustre/atlas/world-shared/csc121/uvcdat/2015-05-06/lib/python2.7/ast.py", line 80, in literal_eval
    return _convert(node_or_string)
  File "/lustre/atlas/world-shared/csc121/uvcdat/2015-05-06/lib/python2.7/ast.py", line 79, in _convert
    raise ValueError('malformed string')
ValueError: malformed string

@vvpalav
Copy link
Contributor Author

vvpalav commented May 13, 2015

pull and check now please

@doutriaux1
Copy link
Contributor

works now. Thanks!

doutriaux1 added a commit that referenced this pull request May 13, 2015
Changed port for ext_1 and ext_2 to Boolean from String
@doutriaux1 doutriaux1 merged commit 4906aa2 into uvcdat-master May 13, 2015
@remram44 remram44 deleted the 1306_change_extensions_to_boolean branch May 13, 2015 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants