-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ansible vagrant install #1490
Ansible vagrant install #1490
Conversation
It is installed via a very simple ansible script
This doesn't trigger other builders because it is from an external repository. It doesn't really matter in this case because it is only devops content. |
I am not sure if it should even go in the main uvcdat repo or if I should just keep it on my fork, just wanted to put it out there for comments just in case. |
It's a little bit contrived for your use case, but so is the Dockerfile for cdatweb. I think it is useful enough to serve as an example of a deployment method. I'll wait for some else to give the final okay though. |
@aashish24 I'm ok with merging this, I will let you have the final say. |
@zachmullen @doutriaux1 I only have one suggestion. Can we move these files to its own specific folder (may be create deploy at the root level?) and then move docker and these there? |
That is possible, it may require a reconfigure of server-side hooks on docker hub if they exist for the current docker file though. |
The |
We don't currently have any automated docker deployments (dockerhub fails to build for some unknown reason). Dockerfiles don't support |
@aashish24 I moved the ansible and docker code under a "deploy" directory. |
thanks @zachmullen. LGTM 👍 |
(BTW I don't have write access to this repo) |
I will add you. In the mean time, I am merging this. |
@doutriaux1 is it okay to add @zachmullen ? |
of course. |
No description provided.