Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible vagrant install #1490

Merged
merged 3 commits into from Aug 18, 2015
Merged

Conversation

@zachmullen
Copy link
Contributor

@zachmullen zachmullen commented Aug 13, 2015

No description provided.

@jbeezley
Copy link

@jbeezley jbeezley commented Aug 14, 2015

This doesn't trigger other builders because it is from an external repository. It doesn't really matter in this case because it is only devops content.

@zachmullen
Copy link
Contributor Author

@zachmullen zachmullen commented Aug 14, 2015

I am not sure if it should even go in the main uvcdat repo or if I should just keep it on my fork, just wanted to put it out there for comments just in case.

@jbeezley
Copy link

@jbeezley jbeezley commented Aug 14, 2015

It's a little bit contrived for your use case, but so is the Dockerfile for cdatweb. I think it is useful enough to serve as an example of a deployment method. I'll wait for some else to give the final okay though.

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Aug 17, 2015

@aashish24 I'm ok with merging this, I will let you have the final say.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Aug 17, 2015

@zachmullen @doutriaux1 I only have one suggestion. Can we move these files to its own specific folder (may be create deploy at the root level?) and then move docker and these there?

@zachmullen
Copy link
Contributor Author

@zachmullen zachmullen commented Aug 17, 2015

That is possible, it may require a reconfigure of server-side hooks on docker hub if they exist for the current docker file though.

@jbeezley
Copy link

@jbeezley jbeezley commented Aug 17, 2015

The Dockerfile at the root actually needs to be there, but you can move the /docker directory anywhere.

@jbeezley
Copy link

@jbeezley jbeezley commented Aug 17, 2015

We don't currently have any automated docker deployments (dockerhub fails to build for some unknown reason). Dockerfiles don't support ADD-ing files from parent directories, so we would need a manual step to copy the Dockerfile to the root. I'm not even sure if that is possible in dockerhub.

@zachmullen
Copy link
Contributor Author

@zachmullen zachmullen commented Aug 17, 2015

@aashish24 I moved the ansible and docker code under a "deploy" directory.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Aug 17, 2015

thanks @zachmullen. LGTM 👍

@zachmullen
Copy link
Contributor Author

@zachmullen zachmullen commented Aug 18, 2015

(BTW I don't have write access to this repo)

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Aug 18, 2015

I will add you. In the mean time, I am merging this.

aashish24 added a commit that referenced this issue Aug 18, 2015
@aashish24 aashish24 merged commit 500bc57 into CDAT:master Aug 18, 2015
1 check passed
@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Aug 18, 2015

@doutriaux1 is it okay to add @zachmullen ?

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Aug 24, 2015

of course.

@zachmullen zachmullen deleted the ansible-vagrant-install branch Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants