-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animations will properly resume when resizing #1634
Conversation
@chaosphere2112 I will review it today. |
@chaosphere2112 I was able to reproduce the bug now working on testing your code. |
@chaosphere2112 LGTM 👍 I see failures on dashboards but it does not seem to related to this branch. |
Ship it! |
It looks like garant has been failing since about 9/23 (that was the last nightly to pass). Looking back through cdash, my guess is that #1563 is the cause. FWIW, the output image looks something like the resizing bug that occurs in cdatweb. The axes and text don't look like they have redrawn yet. Another thing I noticed is that this test is much faster on garant than on the other dashboard machines (1.5s vs 5-10s). |
@jbeezley the axes looks right on my Ubuntu box when I merged Sam's branch into master. Can you post your screen captures? |
Yes, it doesn't have anything to do with these changes. Like I said, it has shown up on the nightlies for over a month. For example here: https://open.cdash.org/testDetails.php?test=383120267&build=4070878 |
Ah, thanks, I misunderstood what you said earlier. That test has been failing for sometime. @doutriaux1 are you going to look at it? Do you think its a more general issue like what @jbeezley is talking about? |
Animations will properly resume when resizing
@chaosphere2112 looks like we need to tell test_vcs_click_info an actual size of screen to use, my guess is that on garant VTK is actually able to get the screensize (unlike on most other machines) and uses it to set a different value. |
@doutriaux1 That would make sense... I can do that. |
or may be its getting a different size since I don't know how VTK would behave differently. |
@aashish24 It's been very odd. I've got installs where it correctly determines the size and ones where it doesn't (different OSX versions, mostly). |
The VTK API returns a pointer so unless the API changed, I don't know how it can return a number. But I haven't look at the code recently. |
|
On garant: In [1]: import vtk
In [2]: w = vtk.vtkRenderWindow()
In [3]: w.GetScreenSize()
Out[3]: '_000000000116fac0_p_void'
In [4]: w.GetDPI()
Out[4]: 72 |
That's with VTK commit 6d67334. |
I'm on CDAT/VTK@ec6c6ab |
Yeah, that was an old build. But using the latest CDAT/VTK@ec6c6ab, I still get In [3]: w.GetScreenSize()
Out[3]: '_00000000025c9c40_p_void' |
This was supposedly fixed in CDAT/VTK@0541472. Maybe some other render window classes need the type hinting added. |
For the record, that is using
|
@jbeezley that sounds like a possibility. On my ubuntu as well I am getting a pointer but may for Mac, we have the type hinting set. @dlonie care to look into it? |
Sure enough, looks like the hints file is missing a definition for Actually, on second look, it's a typo. There are hints provided for @jbeezley Can you try patching the hints file on your local build to correct the name and see if that fixes it? I can prepare a patch if that fixes it. |
Sure. |
Yup, that fixed it. diff --git a/Wrapping/Tools/hints b/Wrapping/Tools/hints
index c36c49e..78a6dfe 100644
--- a/Wrapping/Tools/hints
+++ b/Wrapping/Tools/hints
@@ -282,7 +282,7 @@ vtkWindowLevelLookupTable GetMaximumTableValue 307 4
vtkWindowLevelLookupTable GetMinimumTableValue 307 4
vtkXImageWindow GetPosition 304 2
vtkXImageWindow GetSize 304 2
-vtkXRenderWindow GetPosition 304 2
-vtkXRenderWindow GetScreenSize 304 2
-vtkXRenderWindow GetSize 304 2
+vtkXOpenGLRenderWindow GetPosition 304 2
+vtkXOpenGLRenderWindow GetScreenSize 304 2
+vtkXOpenGLRenderWindow GetSize 304 2
vtkXYPlotActor GetPlotColor 307 3 |
Addresses the buggy part of #1629; performance fix will be a separate PR (I know the source of the issue, there will be an extensive writeup as part of that PR, which I hope to have up by end of day today).