Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce CMake minimum version 2.8.12 #1756

Merged
merged 1 commit into from Jan 6, 2016
Merged

Enforce CMake minimum version 2.8.12 #1756

merged 1 commit into from Jan 6, 2016

Conversation

@sankhesh
Copy link
Contributor

@sankhesh sankhesh commented Jan 6, 2016

Fixes #1751

@sankhesh
Copy link
Contributor Author

@sankhesh sankhesh commented Jan 6, 2016

@doutriaux1 @jbeezley Please review

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Jan 6, 2016

Is it only to fix the issue with the message telling us where openssl is? If so I would rather not do this. We have a lot of RH6 system where this change will force them to upgrade to their cmake making the build seem even more painful. I tested it on RH6 by commenting out this message and it's all good and happy, wouldn't it be better to simply remove the DIRECTORY directive in the message here ?

@sankhesh sankhesh force-pushed the 1751_cmake_version branch 2 times, most recently from a11c015 to 2cbc02e Jan 6, 2016
This change fixes #1751 by introducing backwards
compatibility for older CMake version provided by RH6 package
manager.
@sankhesh sankhesh force-pushed the 1751_cmake_version branch from 2cbc02e to f8885ec Jan 6, 2016
doutriaux1 added a commit that referenced this issue Jan 6, 2016
Enforce CMake minimum version 2.8.12
@doutriaux1 doutriaux1 merged commit 01feb47 into master Jan 6, 2016
3 of 8 checks passed
@doutriaux1 doutriaux1 deleted the 1751_cmake_version branch Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants