New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce CMake minimum version 2.8.12 #1756

Merged
merged 1 commit into from Jan 6, 2016

Conversation

Projects
None yet
2 participants
@sankhesh
Contributor

sankhesh commented Jan 6, 2016

Fixes #1751

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Jan 6, 2016

@doutriaux1 @jbeezley Please review

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jan 6, 2016

Is it only to fix the issue with the message telling us where openssl is? If so I would rather not do this. We have a lot of RH6 system where this change will force them to upgrade to their cmake making the build seem even more painful. I tested it on RH6 by commenting out this message and it's all good and happy, wouldn't it be better to simply remove the DIRECTORY directive in the message here ?

@sankhesh sankhesh force-pushed the 1751_cmake_version branch 2 times, most recently from a11c015 to 2cbc02e Jan 6, 2016

Support for CMake versions older than 2.8.12
This change fixes #1751 by introducing backwards
compatibility for older CMake version provided by RH6 package
manager.

@sankhesh sankhesh force-pushed the 1751_cmake_version branch from 2cbc02e to f8885ec Jan 6, 2016

doutriaux1 added a commit that referenced this pull request Jan 6, 2016

Merge pull request #1756 from UV-CDAT/1751_cmake_version
Enforce CMake minimum version 2.8.12

@doutriaux1 doutriaux1 merged commit 01feb47 into master Jan 6, 2016

3 of 8 checks passed

cont-int/LLNL/Linux-RH6 (FULL) running 'ctest -j15 -D Experimental' (Wed Jan 6 09:48:55 2016)
Details
cont-int/LLNL/Linux-Ub. 15.10 (FULL/MESA) running 'ctest -j15 -D Experimental' (Wed Jan 6 10:29:06 2016)
Details
cont-int/LLNL/Darwin-Mac (FULL) running 'In Queue: 1' (Wed Jan 6 08:44:56 2016)
Details
cont-int/LLNL/Darwin-Mac (NOGUI) running 'In Queue: 1' (Wed Jan 6 08:44:56 2016)
Details
cont-int/LLNL/Darwin-Mac LEAN running 'make -j4' (Wed Jan 6 08:53:01 2016)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the 1751_cmake_version branch Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment