Enforce CMake minimum version 2.8.12 #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doutriaux1 @jbeezley Please review |
|
Is it only to fix the issue with the message telling us where openssl is? If so I would rather not do this. We have a lot of RH6 system where this change will force them to upgrade to their cmake making the build seem even more painful. I tested it on RH6 by commenting out this message and it's all good and happy, wouldn't it be better to simply remove the |
sankhesh
force-pushed
the
1751_cmake_version
branch
2 times, most recently
from
a11c015
to
2cbc02e
Compare
This change fixes #1751 by introducing backwards compatibility for older CMake version provided by RH6 package manager.
sankhesh
force-pushed
the
1751_cmake_version
branch
from
2cbc02e
to
f8885ec
Compare
doutriaux1
added a commit
that referenced
this pull request
Jan 6, 2016
Enforce CMake minimum version 2.8.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1751