Fit to viewport cleanup #1806
Fit to viewport cleanup #1806
Conversation
Fail to recognize that ym,yM are not the min/max for axis Y, but just the bounds for this axis. Very misleading notation, by the way.
Those are margins for increasing or decreasing sequences not bounds. So m is not less than M as suggested by the previous notation.
|
@aashish24 @doutriaux1 Now we only use dataset bounds to do the parallel projection and draw the contours and continents. Markings and labels are a little off as they still use gm bounds. We could merge this as is and start working on replacing marking and labels with VTK axis. This would save us a couple of days of work. I understand this is the plan anyway. What do you think? |
|
@doutriaux1 @aashish24 I am very curious about the lambert test on macs - I enable it because the failure I have seen (not the segfault) was happening because the outline and continents were off. Now this is done differently so lets see what happen. |
|
@danlipsa i would like to replace vthe whole template.plot with a real vtk backend! It would be so much nicer! But there are a LOT of subtleties in there (user custom axes labels, log scaling etc...) so we will have to be very careful when doing this. |
|
@doutriaux1 I am sure it won't be easy. Depending on how long it will take to add the new markings and labels in we might want to fix the labels now even if we know we are going to replace this code in the near future. I'll talk to @aashish24 about this as we have a meeting at 11. |
|
@doutriaux1 @aashish24 just confirmed that the VTK work is going to be longer as it involves some other things so I'll go ahead and work on fixing the labels for now. |
|
@danlipsa yes I think it's the best approach for now. |
|
@doutriaux1 Seems some mac buildbots are stuck. On one of them, the lambert test passed. |
danlipsa
force-pushed
the
fit-to-viewport-cleanup
branch
2 times, most recently
from
6288311
to
05d7469
Compare
danlipsa
force-pushed
the
fit-to-viewport-cleanup
branch
from
05d7469
to
80d8e36
Compare
|
@doutriaux1 @aashish24 Please review. I think the trickiest change is the one in vectorpipeline.py. In there we overlap a vector plot over a boxfill plot. Given that these have different bounds I had to adjust the viewport where the vector plot ends up so that the two plots align properly. Note the mac buildbots are stuck. |
|
@danlipsa restarted macbots |
|
Thanks @doutriaux1. lambert tests look a lot better on macs with the new code. @aashish24 @doutriaux1 Are you guys OK with adding new baselines for these failures? Some labels move a little maybe because of a difference in floating point calculations or maybe of a bug in proj4. I don't think it is worth looking into why. |
|
@danlipsa why are the ticks so up high on mac? (which is what the tests fail). |
|
@doutriaux1 Not sure. It may have to do with the different proj4 behavior on macs. Given that aeqd is not right anyway, I would suggest adding new baselines for these tests and taking another look with the new proj4 which I remember fixes some aeqd stuff. |
|
|
Yay! Hopefully we won't have branches in future with so many baselines updates. I keep saying this. |
No description provided.