-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG #1770: Display meshfill template elements through renderTemplate. #2049
Conversation
Baselines in |
@doutriaux1 @aashish24 @chaosphere2112 Please review. Before calling Canvas.plotlist: 28 After calling plot with my fix:list: 28 After calling plot without my fix:list: 28 |
Note texttable, textorientation, textcombined are increasing and also display is at 2 not at 1. |
@danlipsa This is the memory leak I referred to in @durack1's issues. @doutriaux1 was going to take a look at it |
@danlipsa #1424 is what @chaosphere2112 was talking about.. I'd be more than happy to kick the tires on a branch here, my plot slowdowns and memory usage (~100GB for a ~6800 loop) is pretty extreme |
Do: test |
Testing commands handed to buildbot. Branch-at: abbfec5 |
This deletes some displays which reduces memory leaks.
@doutriaux1 @aashish24 This has been ready for a while. Please review. |
Do: test |
Testing commands handed to buildbot. Branch-at: 3873bdc |
@sankhesh buildbot does not seem to pickup uvcdat-testdata. I know it should be done by make, but it does not seem to happen in the latest cdath results on this PR. Is there a way to see the SHA for the test data? |
@danlipsa I have a lot of failed tests due to image sizes being different on my mac see: https://open.cdash.org/viewTest.php?onlyfailed&buildid=4475287 Some of them are due to conda env not being activated properly (I think it is because I was also messing with my conda envs as I was running the test suite) |
anyway issues not related to your changes so merged. |
This deletes some displays which reduces memory leaks.