Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG #1770: Display meshfill template elements through renderTemplate. #2049

Merged
merged 1 commit into from Jul 26, 2016

Conversation

@danlipsa
Copy link
Contributor

@danlipsa danlipsa commented Jul 8, 2016

This deletes some displays which reduces memory leaks.

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Jul 8, 2016

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Jul 8, 2016

@doutriaux1 @aashish24 @chaosphere2112 Please review.
A question for uvcdat old-timers: Why is template.plot (and maybe other parts of the code) storing stuff in vcs.elements? I printed vcs.elements before and after doing a plot:
display is decreased from 8 to 2.

Before calling Canvas.plot

list: 28
projection: 10
texttable: 9
textorientation: 63
textcombined: 0
line: 17
marker: 9
fillarea: 1
font: 16
fontNumber: 16
boxfill: 9
isofill: 9
isoline: 9
meshfill: 7
3d_scalar: 2
3d_dual_scalar: 1
3d_vector: 1
template: 77
taylordiagram: 1
1d: 13
vector: 1
yxvsx: 1
xyvsy: 1
xvsy: 1
scatter: 1
colormap: 22
display: 1

After calling plot with my fix:

list: 28
projection: 10
texttable: 21
textorientation: 75
textcombined: 12
line: 17
marker: 9
fillarea: 1
font: 16
fontNumber: 16
boxfill: 9
isofill: 9
isoline: 9
meshfill: 8
3d_scalar: 2
3d_dual_scalar: 1
3d_vector: 1
template: 77
taylordiagram: 1
1d: 13
vector: 1
yxvsx: 1
xyvsy: 1
xvsy: 1
scatter: 1
colormap: 22
display: 2

After calling plot without my fix:

list: 28
projection: 10
texttable: 21
textorientation: 75
textcombined: 12
line: 17
marker: 9
fillarea: 1
font: 16
fontNumber: 16
boxfill: 9
isofill: 9
isoline: 9
meshfill: 8
3d_scalar: 2
3d_dual_scalar: 1
3d_vector: 1
template: 77
taylordiagram: 1
1d: 13
vector: 1
yxvsx: 1
xyvsy: 1
xvsy: 1
scatter: 1
colormap: 22
display: 8

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Jul 8, 2016

Note texttable, textorientation, textcombined are increasing and also display is at 2 not at 1.

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Jul 12, 2016

@danlipsa This is the memory leak I referred to in @durack1's issues. @doutriaux1 was going to take a look at it

@durack1
Copy link
Member

@durack1 durack1 commented Jul 12, 2016

@danlipsa #1424 is what @chaosphere2112 was talking about.. I'd be more than happy to kick the tires on a branch here, my plot slowdowns and memory usage (~100GB for a ~6800 loop) is pretty extreme

@kwrobot
Copy link
Member

@kwrobot kwrobot commented Jul 18, 2016

Basic content checks passed!

Branch-at: abbfec5
Acked-by: @kwrobot

@sankhesh
Copy link
Contributor

@sankhesh sankhesh commented Jul 18, 2016

Do: test

@kwrobot
Copy link
Member

@kwrobot kwrobot commented Jul 18, 2016

Testing commands handed to buildbot.

Branch-at: abbfec5

@kwrobot
Copy link
Member

@kwrobot kwrobot commented Jul 18, 2016

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: abbfec5

This deletes some displays which reduces memory leaks.
@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Jul 26, 2016

@kwrobot
Copy link
Member

@kwrobot kwrobot commented Jul 26, 2016

Basic content checks passed!

Changes since last check: compare

Branch-at: 3873bdc
Acked-by: @kwrobot

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Jul 26, 2016

Do: test

@kwrobot
Copy link
Member

@kwrobot kwrobot commented Jul 26, 2016

Testing commands handed to buildbot.

Branch-at: 3873bdc

@kwrobot
Copy link
Member

@kwrobot kwrobot commented Jul 26, 2016

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: 3873bdc

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Jul 26, 2016

@sankhesh buildbot does not seem to pickup uvcdat-testdata. I know it should be done by make, but it does not seem to happen in the latest cdath results on this PR. Is there a way to see the SHA for the test data?

@doutriaux1 doutriaux1 merged commit 63a4221 into master Jul 26, 2016
3 of 5 checks passed
@doutriaux1 doutriaux1 deleted the meshfill_leak branch Jul 26, 2016
@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Jul 26, 2016

@danlipsa I have a lot of failed tests due to image sizes being different on my mac see: https://open.cdash.org/viewTest.php?onlyfailed&buildid=4475287

Some of them are due to conda env not being activated properly (I think it is because I was also messing with my conda envs as I was running the test suite)

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Jul 26, 2016

anyway issues not related to your changes so merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants