Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meshfill leaves extra display plots lying around #1770

Closed
chaosphere2112 opened this issue Jan 7, 2016 · 3 comments
Closed

Meshfill leaves extra display plots lying around #1770

chaosphere2112 opened this issue Jan 7, 2016 · 3 comments
Assignees
Milestone

Comments

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Jan 7, 2016

When you plot a meshfill, it generates a bunch of display plots that need to be cleaned up. The offending code is here; in the rest of the pipelines, rather than directly calling template.plot, we call context().render_template, which does this cleanup for us (as well as plotting time/date stamps in the top right). I tried using render_template instead of template.plot, but it horribly breaks things (You can see the dashboard results here). @doutriaux1 and I agree that this issue can wait till 2.6.

@durack1
Copy link
Member

@durack1 durack1 commented Jan 7, 2016

@chaosphere2112 this might be somewhat kinda related to #1424 - in that plot functions are not cleaning up after themselves correctly..?

@chaosphere2112
Copy link
Contributor Author

@chaosphere2112 chaosphere2112 commented Jan 7, 2016

@durack1 Similar, but different; these get cleaned up when calling vcs.clear.

danlipsa added a commit that referenced this issue Jul 8, 2016
This deletes some displays which reduces memory leaks.
danlipsa added a commit that referenced this issue Jul 8, 2016
This deletes some displays which reduces memory leaks.
danlipsa added a commit that referenced this issue Jul 25, 2016
This deletes some displays which reduces memory leaks.
doutriaux1 added a commit that referenced this issue Jul 26, 2016
BUG #1770: Display meshfill template elements through renderTemplate.
@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Apr 9, 2019

migrated to vcs

@doutriaux1 doutriaux1 closed this Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants