New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meshfill leaves extra display plots lying around #1770

Open
chaosphere2112 opened this Issue Jan 7, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@chaosphere2112
Contributor

chaosphere2112 commented Jan 7, 2016

When you plot a meshfill, it generates a bunch of display plots that need to be cleaned up. The offending code is here; in the rest of the pipelines, rather than directly calling template.plot, we call context().render_template, which does this cleanup for us (as well as plotting time/date stamps in the top right). I tried using render_template instead of template.plot, but it horribly breaks things (You can see the dashboard results here). @doutriaux1 and I agree that this issue can wait till 2.6.

@chaosphere2112 chaosphere2112 added this to the 2.6 milestone Jan 7, 2016

@durack1

This comment has been minimized.

Member

durack1 commented Jan 7, 2016

@chaosphere2112 this might be somewhat kinda related to #1424 - in that plot functions are not cleaning up after themselves correctly..?

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Jan 7, 2016

@durack1 Similar, but different; these get cleaned up when calling vcs.clear.

danlipsa added a commit that referenced this issue Jul 8, 2016

BUG #1770: Display meshfill template elements through renderTemplate.
This deletes some displays which reduces memory leaks.

danlipsa added a commit that referenced this issue Jul 8, 2016

BUG #1770: Display meshfill template elements through renderTemplate.
This deletes some displays which reduces memory leaks.

@danlipsa danlipsa added 3 - Review and removed 2 - Working <= 5 labels Jul 8, 2016

danlipsa added a commit that referenced this issue Jul 25, 2016

BUG #1770: Display meshfill template elements through renderTemplate.
This deletes some displays which reduces memory leaks.

doutriaux1 added a commit that referenced this issue Jul 26, 2016

Merge pull request #2049 from UV-CDAT/meshfill_leak
BUG #1770: Display meshfill template elements through renderTemplate.

@danlipsa danlipsa added 4 - Done and removed 3 - Review labels Aug 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment