/vcs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drawMarker and legend cannot not draw a line. #289

Closed
doutriaux1 opened this Issue Dec 18, 2017 · 2 comments

Comments

Assignees

@doutriaux1 doutriaux1

Labels
Projects
None yet
Milestone
  8.0
2 participants
@doutriaux1 @chengzhuzhang
@doutriaux1
Member

doutriaux1 commented Dec 18, 2017

need a mechanism to allow for not drawing a line

@doutriaux1 doutriaux1 added the enhancement label Dec 18, 2017

@doutriaux1 doutriaux1 added this to the 3.0 milestone Dec 18, 2017

@doutriaux1 doutriaux1 self-assigned this Dec 18, 2017

@doutriaux1

This comment has been minimized.

Sign in to view
Member

doutriaux1 commented Dec 18, 2017

to be precise you can turn off a line by setting its width to 0, BUT the legend spacing always assume a line is going to be drawn.

doutriaux1 added a commit that referenced this issue Dec 18, 2017

@doutriaux1
fix #289
f406203

doutriaux1 added a commit that referenced this issue Dec 18, 2017

@doutriaux1
fix #289
Loading status checks…
45305a8

doutriaux1 added a commit that referenced this issue Dec 18, 2017

@doutriaux1
merged in #289
fa6e0c4
@chengzhuzhang

This comment has been minimized.

Sign in to view

chengzhuzhang commented Dec 19, 2017

It looks good to me. Makes sense now! I think matplotlib has similar function.

@doutriaux1 doutriaux1 closed this in a45581f Dec 20, 2017

doutriaux1 added a commit that referenced this issue Dec 21, 2017

@doutriaux1
Issue 291 limt font downscaling (#292) 
* fix #289

* fix #289

* merged in #289

* fix #291
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
65086ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment