Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set startseed for streamlines to None = middle of the domain. #304

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

danlipsa
Copy link
Contributor

No description provided.

@doutriaux1
Copy link
Contributor

@danlipsa should we add a test for this?

@danlipsa
Copy link
Contributor Author

I looked to modify the tests we have to not set the startseed. I turns out that startseed is already not set.
The previous default was [0, 0, 0] which was the startseed.
Now the default is None which sets startseed to the middle of the domain which is [0,0,0]. So we end-up with the same streamlines.
This this new code path is already tested by the tests we have.

@doutriaux1 doutriaux1 merged commit b420752 into master Jan 29, 2018
@doutriaux1 doutriaux1 deleted the startseed branch January 29, 2018 18:03
@danlipsa
Copy link
Contributor Author

Fixes
#269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants