-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save FHIR data to S3 in ecr-viewer #1456
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1456 +/- ##
=======================================
Coverage 96.94% 96.94%
=======================================
Files 48 48
Lines 3048 3048
=======================================
Hits 2955 2955
Misses 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some thoughts about the jsdocs, and the NextResponse not being consistently created throughout the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for making those changes 🎉
PULL REQUEST
Summary
save-fhir-data
API route to save to s3setup-local-env
script inpackage.json
to automate the setup of.env.local
Related Issue
Fixes #1344
Additional Information
These tests aren't true integration tests (doesn't spin up an s3 instance, etc.,).
Checklist
Example request body: