Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save FHIR data to S3 in ecr-viewer #1456

Merged
merged 16 commits into from
Mar 12, 2024
Merged

Save FHIR data to S3 in ecr-viewer #1456

merged 16 commits into from
Mar 12, 2024

Conversation

angelathe
Copy link
Collaborator

@angelathe angelathe commented Mar 11, 2024

PULL REQUEST

Summary

  • Add function in save-fhir-data API route to save to s3
  • Adds tests that mock s3
  • Add setup-local-env script in package.json to automate the setup of .env.local

Related Issue

Fixes #1344

Additional Information

These tests aren't true integration tests (doesn't spin up an s3 instance, etc.,).

Checklist

Example request body:

{
    "fhirBundle": {
        "resourceType": "Bundle",
        "type": "batch",
        "entry": [
        {
            "fullUrl": "urn:uuid:12345",
            "resource": {
                "resourceType": "Composition",
                "id": "12345"
            }
        }
        ]
    },
    "saveSource": "s3"
}

@angelathe angelathe marked this pull request as ready for review March 11, 2024 20:29
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (54e84ad) to head (f4825fc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1456   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files          48       48           
  Lines        3048     3048           
=======================================
  Hits         2955     2955           
  Misses         93       93           
Flag Coverage Δ
unit-tests 96.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some thoughts about the jsdocs, and the NextResponse not being consistently created throughout the file.

@angelathe angelathe requested a review from BobanL March 12, 2024 17:27
Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for making those changes 🎉

@angelathe angelathe added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit b54f8ca Mar 12, 2024
40 checks passed
@angelathe angelathe deleted the 1344/save-fhir-data-s3 branch March 12, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save data from eCR Viewer to S3 bucket
4 participants