Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to eCR Viewer homepage #1889

Merged
merged 5 commits into from
May 28, 2024
Merged

Conversation

angelathe
Copy link
Collaborator

PULL REQUEST

Summary

  • Adds pagination to eCR viewer homepage (# of items per page currently set to 25)
  • Adds unit tests, updates snapshot test

Related Issue

Fixes #1782

Screenshot

In order to see how the pagination functions, I temporarily set the # items per page to 10
https://github.com/CDCgov/phdi/assets/40042932/9455067a-d450-4b01-81b0-0ebdd1b90209

With items per page set to 25 (since there are < 25 items total, this is what the single page looks like)
Screenshot 2024-05-21 at 23 05 11

Additional Information

USWDS Storybook: Pagination

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@angelathe angelathe self-assigned this May 22, 2024
@angelathe angelathe requested a review from sarahtress May 22, 2024 19:20
@sarahtress
Copy link
Collaborator

@angelathe this looks pretty close to me, only thing is the spacing between the bottom of the table and the pagination component should be 48px. it looks a little bigger than that right now

@angelathe
Copy link
Collaborator Author

@angelathe this looks pretty close to me, only thing is the spacing between the bottom of the table and the pagination component should be 48px. it looks a little bigger than that right now

Ahh good catch, just fixed! Kept the gap at 48px, but removed the bottom margin of the table / top margin of the pagination.
Screenshot 2024-05-22 at 14 58 58

@sarahtress
Copy link
Collaborator

@angelathe this looks pretty close to me, only thing is the spacing between the bottom of the table and the pagination component should be 48px. it looks a little bigger than that right now

Ahh good catch, just fixed! Kept the gap at 48px, but removed the bottom margin of the table / top margin of the pagination. Screenshot 2024-05-22 at 14 58 58

awesome looks good to me!

@angelathe angelathe marked this pull request as ready for review May 23, 2024 18:24
Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

I will note that when running accessibility scan it did flag the next page arrow image (>). This was reported already.

@angelathe angelathe added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit d042152 May 28, 2024
45 checks passed
@angelathe angelathe deleted the angela/1782-paginate-home branch May 28, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paginate eCR Viewer homepage
3 participants