-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Otel #1891
Docker Otel #1891
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1891 +/- ##
=======================================
Coverage 97.01% 97.01%
=======================================
Files 48 48
Lines 3053 3053
=======================================
Hits 2962 2962
Misses 91 91
Flags with carried forward coverage won't be shown. Click here to find out more. |
containers/ecr-viewer/package.json
Outdated
@@ -19,11 +19,17 @@ | |||
"dependencies": { | |||
"@aws-sdk/client-s3": "^3.515.0", | |||
"@opentelemetry/api": "^1.7.0", | |||
"@opentelemetry/auto-instrumentations-node": "^0.46.1", | |||
"@opentelemetry/auto-instrumentations-node": "^0.46.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the change from 0.46.1 to 0.46.0 due to a conflict?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PULL REQUEST
Summary
What changes are being proposed?
Related Issue
Fixes #
Additional Information
Anything else the review team should know?
Checklist