Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Otel #1891

Merged
merged 24 commits into from
May 30, 2024
Merged

Docker Otel #1891

merged 24 commits into from
May 30, 2024

Conversation

KennethSkylight
Copy link
Collaborator

PULL REQUEST

Summary

What changes are being proposed?

Related Issue

Fixes #

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.01%. Comparing base (f7351b3) to head (ed2b59d).
Report is 7 commits behind head on main.

Current head ed2b59d differs from pull request most recent head 0c63eec

Please upload reports for the commit 0c63eec to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1891   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files          48       48           
  Lines        3053     3053           
=======================================
  Hits         2962     2962           
  Misses         91       91           
Flag Coverage Δ
unit-tests 97.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@ -19,11 +19,17 @@
"dependencies": {
"@aws-sdk/client-s3": "^3.515.0",
"@opentelemetry/api": "^1.7.0",
"@opentelemetry/auto-instrumentations-node": "^0.46.1",
"@opentelemetry/auto-instrumentations-node": "^0.46.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the change from 0.46.1 to 0.46.0 due to a conflict?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revert

containers/ecr-viewer/docker-compose.yml Show resolved Hide resolved
Copy link
Collaborator

@marycrawford marycrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KennethSkylight KennethSkylight added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit 88236af May 30, 2024
45 checks passed
@KennethSkylight KennethSkylight deleted the docker-otel-2 branch May 30, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants