8395 [Manage Public Key] Add new route, and basic page #8665
Conversation
penny-lischer
added
frontend
penny-lischer
force-pushed
the
experience/8395/public-key-tool
branch
from
4c7c911
to
0006c1a
Compare
|
|
||
| export function ManagePublicKey() { | ||
| return ( | ||
| <div className="grid-container margin-bottom-5 tablet:margin-top-6"> |
There was a problem hiding this comment.
Let's use paddings instead of margins when we're restricting widths/heights of contents; margins are meant for spacings between elements rather than dictating the descendant content flow, and vertical margins are also susceptible to collapse, which can happen unintentionally especially between top-level elements of components.
There was a problem hiding this comment.
Just following the way we have it throughout the site but can change it. Will also change from <div> to <section> per your comment below.
frontend-react/src/components/ManagePublicKey/ManagePublicKey.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| export function ManagePublicKey() { | ||
| return ( | ||
| <div className="grid-container margin-bottom-5 tablet:margin-top-6"> |
There was a problem hiding this comment.
Another point is that react-uswds provides some atomic elements for things like the grid container, which I think we should start using despite the fact that they're very thin wrappers around modifier classes. Even if we move off of react-uswds, it'll be easier to make the migration to another library or our own component system if we have one consistent way of treating them now instead of modifier classes.
@etanb @jpandersen87 Thoughts?
There was a problem hiding this comment.
As long as USWDS' grid is just shortcuts to flexbox (and thus react-uswds' grid) it sounds fine to me.
* Added ability to remove filtered conditions from a bundle --------- Co-authored-by: Jessica Willis <jessicawillis@navapbc.com>
* Update to Node 18 Fixes #7078
- Changed <div> to <GridContainer>. - Removed extra <div>
- Fix lint error
|
SonarCloud Quality Gate failed. |
This PR ...
Adds a new route and page for the Public Key Tool
Test Steps:
Changes
Checklist
Testing
./prime testor./gradlew testSmokeagainst local Docker ReportStream container?npm run lint:write?Linked Issues