Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8395 [Manage Public Key] Add new route, and basic page #8665

Merged
merged 8 commits into from
Mar 10, 2023
Merged

8395 [Manage Public Key] Add new route, and basic page #8665

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c3f0fe5
8395 [Manage Public Key] Add new route, and basic page
penny-lischer Mar 9, 2023
0006c1a
8395 [Manage Public Key] Add new route, and basic page
penny-lischer Mar 9, 2023
552fc0a
Merge branch 'master' into experience/8395/public-key-tool
penny-lischer Mar 9, 2023
284ebed
8098 generate condition filtered FHIR bundle (#8600)
victor-chaparro Mar 10, 2023
22b36ce
Update to Node 18.15 (#8631)
jpandersen87 Mar 10, 2023
7d626ad
8395 [Manage Public Key]
penny-lischer Mar 10, 2023
832f518
Merge branch 'master' into experience/8395/public-key-tool
snesm Mar 10, 2023
e70b2eb
8395 [Manage Public Key]
penny-lischer Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions frontend-react/src/AppRouter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import { EditReceiverSettingsWithAuth } from "./components/Admin/EditReceiverSet
import { AdminRevHistoryWithAuth } from "./pages/admin/AdminRevHistory";
import { ErrorNoPage } from "./pages/error/legacy-content/ErrorNoPage";
import { MessageDetailsWithAuth } from "./components/MessageTracker/MessageDetails";
import { ManagePublicKeyWithAuth } from "./components/ManagePublicKey/ManagePublicKey";

export enum FeatureName {
DAILY_DATA = "Daily Data",
Expand Down Expand Up @@ -106,6 +107,10 @@ export const appRoutes = [
path: "/admin/revisionhistory/org/:org/settingtype/:settingType",
element: <AdminRevHistoryWithAuth />,
},
{
path: "/resources/manage-public-key",
element: <ManagePublicKeyWithAuth />,
},
{ path: "/file-handler/validate", element: <ValidateWithAuth /> },
/* Handles any undefined route */
{ path: "*", element: <ErrorNoPage /> },
Expand Down
28 changes: 28 additions & 0 deletions frontend-react/src/components/ManagePublicKey/ManagePublicKey.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import React from "react";

import { AuthElement } from "../AuthElement";
import { withCatchAndSuspense } from "../RSErrorBoundary";
import { MemberType } from "../../hooks/UseOktaMemberships";

export function ManagePublicKey() {
return (
<div className="grid-container margin-bottom-5 tablet:margin-top-6">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use paddings instead of margins when we're restricting widths/heights of contents; margins are meant for spacings between elements rather than dictating the descendant content flow, and vertical margins are also susceptible to collapse, which can happen unintentionally especially between top-level elements of components.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just following the way we have it throughout the site but can change it. Will also change from <div> to <section> per your comment below.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another point is that react-uswds provides some atomic elements for things like the grid container, which I think we should start using despite the fact that they're very thin wrappers around modifier classes. Even if we move off of react-uswds, it'll be easier to make the migration to another library or our own component system if we have one consistent way of treating them now instead of modifier classes.

@etanb @jpandersen87 Thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as USWDS' grid is just shortcuts to flexbox (and thus react-uswds' grid) it sounds fine to me.

<div>
penny-lischer marked this conversation as resolved.
Show resolved Hide resolved
<h1 className="margin-top-0 margin-bottom-5">
Manage Public Key
</h1>
<p className="font-sans-md">
Send your public key to begin the REST API authentication
process.
</p>
</div>
</div>
);
}

export const ManagePublicKeyWithAuth = () => (
<AuthElement
element={withCatchAndSuspense(<ManagePublicKey />)}
requiredUserType={MemberType.SENDER}
/>
);