Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add favorite from queue items. #85

Closed
bobold opened this issue Feb 28, 2019 · 6 comments
Closed

Cannot add favorite from queue items. #85

bobold opened this issue Feb 28, 2019 · 6 comments

Comments

@bobold
Copy link

bobold commented Feb 28, 2019

There seems to be no way to add to favourites...? am I missing something...?
Standard LMS skin has an option to add a radio stream or file to favourites but there appears to be no way to do this in this skin...I have to revert to the default skin for this option.

Otherwise... yes ! this skin is wonderful..!

@CDrummond
Copy link
Owner

Use the vertical "..." button, selcet "Add to favourites"

@CDrummond CDrummond reopened this Feb 28, 2019
@CDrummond CDrummond changed the title No Favourites action ? Cannot add favorite from queue items. Feb 28, 2019
@CDrummond
Copy link
Owner

To be honest, I could add 'Add to favorites' to queue - but the station cover would be missing. Adding the favourite from the browse page will correctly add cover.

Would not be possible to add artist/album/genre favorites (unless poluting the menu with too many options).

So, closing.

@bobold
Copy link
Author

bobold commented Feb 28, 2019 via email

@CDrummond
Copy link
Owner

I have stated my reasons for not implementing this - none of which have to do with being "pretty". I have looked at the default skin - the only way I can save a favourite from the queue is to press the "M" button, this shows more info on the left, and on there is a heart button. I press that button, and a favourite is added - BUT it has neither the station name nor logo. Now neither may be important to you, but I do not find these being missing to be very user friendly. If I could get the station logo, then I'd quite happily add a "Save to favorites" - I'd even written 1/2 the code. But this missing logo stopped me.

However, I'm glad the default skin works for you. I have no issues with it either - apart from it not working on mobile devices.

@bobold
Copy link
Author

bobold commented Feb 28, 2019 via email

@CDrummond
Copy link
Owner

Wow! You really have "issues". I'm sorry I don't want to spend my free time implementing a feature for you that would look 1/2 baked. If looks are so not important, why even consider using this skin? The default web UI actually looks OK to me, and provides what you want - so please use that and leave me alone.

Repository owner locked and limited conversation to collaborators Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants