Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for ssim #67

Merged
merged 5 commits into from
Oct 17, 2019
Merged

fix for ssim #67

merged 5 commits into from
Oct 17, 2019

Conversation

sfarrens
Copy link
Contributor

@sfarrens sfarrens commented Oct 17, 2019

  • Updated SSIM with latest changes to Scikit-Image.
  • Updated corresponding test.

@sfarrens sfarrens added the bug label Oct 17, 2019
@sfarrens sfarrens self-assigned this Oct 17, 2019
@sfarrens sfarrens added this to ToDo in ModOpt-dev via automation Oct 17, 2019
Copy link
Collaborator

@zaccharieramzi zaccharieramzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing

modopt/math/metrics.py Outdated Show resolved Hide resolved
@chaithyagr
Copy link
Contributor

Also, a quick question, does this answer things discussed in CEA-COSMIC/pysap#111 (comment) ?
I am asking this as there is a probability that if the PR CEA-COSMIC/pysap-mri#30 goes through (which it might soon), there could be some changes to examples.
If there are more changes, I could just get another release of pysap-mri

@sfarrens
Copy link
Contributor Author

@chaithyagr This fixes the part b) of my comment. I would prefer not to add Scikit-Image as a mandatory requirement, therefore you should probably add a check to the example to see if Scikit-Image is installed before calculating the SSIM.

@sfarrens sfarrens merged commit e26f55b into CEA-COSMIC:master Oct 17, 2019
ModOpt-dev automation moved this from ToDo to Done Oct 17, 2019
@sfarrens sfarrens deleted the ssim branch October 17, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
ModOpt-dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants