-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MRI Examples #111
Add MRI Examples #111
Conversation
@chaithyagr Have you tested the |
I am not sure, let me do that once. If I remember right, we need to use pynfft from github: pip install git+https://github.com/ghisvail/pyNFFT.git |
I didn't save the output, but the latest PyPi version of pynfft did not compile with Python 3.7. Some Cython issue if I remember correctly. |
I think I faced same issue, the latest PyPi version is not good with some version of pythons and thus we rely on the github version. We could request a new release if needed from ghisvail |
For the moment, I think we should just include a check in the example to see if pynfft is installed, if not raise a warning and exit normally. |
Note that Jyh-Miin Lin will arrive at CEA Grenoble in Oct 21. This should ease the interactions. Once he joins us, I will invite him to slack and open pysap access for him as contributor if everyone agrees on that? |
@philouc note that this is pynfft and not pyNUFFT, we have ongoing PR for best working with pyNUFFT, and surely we will have a round of discussion on that. But for now, we are using NFFT which is developed by Ghishval and which is just a wrapper to nfft3 C library. |
This is exactly what we do in pysap-mri : |
No description provided.