Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding option for pywt Wavelet operator #82

Closed

Conversation

zaccharieramzi
Copy link
Contributor

This PR partially adresses #79 in that it only solves the problem for pywt wavelets.

The default is chosen to be zero-padding in order to have a correct adjoint (that is the inverse transform), instead of the symmetric padding which resulted in an incorrect adjoint operator.

@coveralls
Copy link

coveralls commented Mar 8, 2019

Pull Request Test Coverage Report for Build 210

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 55.533%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pysap/extensions/transform.py 0 6 0.0%
Totals Coverage Status
Change from base Build 206: -0.09%
Covered Lines: 1395
Relevant Lines: 2512

💛 - Coveralls

@AGrigis
Copy link
Contributor

AGrigis commented Mar 26, 2019

Will be fixed after PR #85 merge.
The ISAP case will also be handled.

@AGrigis AGrigis closed this Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants