Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WAV IEEE_FLOAT file format #79

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

andreistoian
Copy link

This PR adds support for the FLOAT32 wave file format. This format is exported by librosa which is commonly used for sound processing in python.

Furthermore a bugfix is added: the chunkSize of wave chunks was not used to skip ahead to the end of the chunk when reading. Thus the extended format chunk was incorrectly read.

For IEEE float format a 'fact' chunk is also present, currently ignored with a notice by the N2D2 parser. Maybe we should silence this notice for FLOAT format.

@olivierbichler-cea
Copy link
Contributor

Hi, thanks for this pull request, could you check the build errors?

@olivierbichler-cea olivierbichler-cea merged commit e3f008a into CEA-LIST:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants