fluids: report TS converged reason and exit cleanly #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedbrown
force-pushed
the
jed/fluids-ts-reason-no-error
branch
from
a115bcb
to
ed3c436
Compare
jedbrown
commented
Jan 7, 2023
jrwrigh
approved these changes
Jan 7, 2023
The final state does not get written by the monitor with the default of -ts_error_if_step_fails 1. Now we exit cleanly regardless of reason, ensuring that the final state checkpoint and monitor has been called.
jedbrown
force-pushed
the
jed/fluids-ts-reason-no-error
branch
from
ed3c436
to
65fa31e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample output now:
and when nonlinear solve fails
Usually one should run with
-snes_converged_reasonand perhaps more SNES/KSP diagnostics to understand why it failed. We could extract and report the most recent of those on divergence in case people are running with those monitors off.