Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CeedElemRestrictionCreateUnsignedCopy #1206

Merged
merged 4 commits into from
May 5, 2023
Merged

Conversation

jeremylt
Copy link
Member

I need to double check the design, but I think this should do what we need.

@jeremylt
Copy link
Member Author

jeremylt commented May 1, 2023

Note to self: I may have a leek on this branch. Need to investigate.

@jeremylt
Copy link
Member Author

jeremylt commented May 2, 2023

Ok, "leek" found and fixed

@sebastiangrimberg
Copy link
Collaborator

I like this idea and wonder if it can be used to simplify #1196 by removing the CeedElemRestrictionApplyUnsigned interface function added there, having the user instead create a copy (CeedElemRestrictionCreateUnsignedCopy) and then just use CeedElemRestrictionApply. This would remove the additions to the API which are now unnecessary.

@jeremylt
Copy link
Member Author

jeremylt commented May 3, 2023

I'd be inclined to move the function to the ceed/backend.h interface if we don't intend it to be used in general anymore.

@jeremylt
Copy link
Member Author

jeremylt commented May 3, 2023

Ok, moved. Really, I should cook up a test for CeedElemRestrictionApplyUnsigned so that there is an easy point of debugging when the GPU backends start adding signed restrictions.

@jeremylt jeremylt merged commit 63fe681 into main May 5, 2023
22 checks passed
@jeremylt jeremylt deleted the jeremy/unsigned-clone branch May 5, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants