-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsigned element restriction for correct operator diagonal assembly #1196
Merged
sebastiangrimberg
merged 6 commits into
CEED:main
from
sebastiangrimberg:sjg/unsigned-restr-dev
Apr 27, 2023
Merged
Unsigned element restriction for correct operator diagonal assembly #1196
sebastiangrimberg
merged 6 commits into
CEED:main
from
sebastiangrimberg:sjg/unsigned-restr-dev
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiangrimberg
force-pushed
the
sjg/unsigned-restr-dev
branch
from
April 17, 2023 22:51
16ddb2b
to
edc1e17
Compare
sebastiangrimberg
changed the title
Unsigned element restriction for correct operator diagonal assembly
WIP: Unsigned element restriction for correct operator diagonal assembly
Apr 17, 2023
sebastiangrimberg
changed the title
WIP: Unsigned element restriction for correct operator diagonal assembly
Unsigned element restriction for correct operator diagonal assembly
Apr 18, 2023
jeremylt
reviewed
Apr 18, 2023
sebastiangrimberg
force-pushed
the
sjg/unsigned-restr-dev
branch
from
April 24, 2023 18:32
edc1e17
to
2ab21da
Compare
jeremylt
reviewed
Apr 24, 2023
jeremylt
reviewed
Apr 24, 2023
…n the case of an oriented element restriction
…ElemRestrictionApply and use backend registration instead
sebastiangrimberg
force-pushed
the
sjg/unsigned-restr-dev
branch
from
April 25, 2023 17:18
57d0363
to
b17517e
Compare
jeremylt
reviewed
Apr 25, 2023
3 tasks
jeremylt
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve #1195 for an element restriction constructed using
CeedElemRestrictionCreateOriented
, and adds a test for H(div) mass from this branch (thank you @rezgarshakeri)Correctly handling #1168 is more complicated and likely should only allow for approximate diagonal assembly using this same
CeedElemRestrictionApplyUnsigned
approach. This is the same strategy used, for example, in MFEM for parallel non-conforming meshes where theP
matrix has a form more complicated than being a simple mapping of local dof to parallel true dof.