Unsigned element restriction for correct operator diagonal assembly #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiangrimberg
force-pushed
the
sjg/unsigned-restr-dev
branch
from
16ddb2b
to
edc1e17
Compare
sebastiangrimberg
changed the title
sebastiangrimberg
changed the title
jeremylt
reviewed
Apr 18, 2023
sebastiangrimberg
force-pushed
the
sjg/unsigned-restr-dev
branch
from
edc1e17
to
2ab21da
Compare
jeremylt
reviewed
Apr 24, 2023
jeremylt
reviewed
Apr 24, 2023
…n the case of an oriented element restriction
…ElemRestrictionApply and use backend registration instead
sebastiangrimberg
force-pushed
the
sjg/unsigned-restr-dev
branch
from
57d0363
to
b17517e
Compare
jeremylt
reviewed
Apr 25, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve #1195 for an element restriction constructed using
CeedElemRestrictionCreateOriented, and adds a test for H(div) mass from this branch (thank you @rezgarshakeri)Correctly handling #1168 is more complicated and likely should only allow for approximate diagonal assembly using this same
CeedElemRestrictionApplyUnsignedapproach. This is the same strategy used, for example, in MFEM for parallel non-conforming meshes where thePmatrix has a form more complicated than being a simple mapping of local dof to parallel true dof.