Update device ID selection for HIP/CUDA/MAGMA backends #740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the device ID selection for the CUDA/HIP backends while retaining the option to use
/gpu/cuda
or/gpu/hip
as shortcuts for the best backends (currently choosesgen
). It also adds the ability to set the device ID for the MAGMA backends.The device ID string was chosen to match that of the OCCA backends, i.e.,
:device_id=#
. An example full resource string would be/gpu/hip/shared:device_id=1
.Other minor changes include:
shared
andgen
backends, and have those backends use the baseCeed_Hip
orCeed_Cuda
structs. (Previously, theshared
andgen
structs only contained aCeed_Hip
orCeed_Cuda
pointer calledbase
, but nothing was ever accessed throughbase
and the CUDA/HIPInit
functions only ever assumed they were given the base struct directly.)Resolves #709