Refactored malduck.extractor #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazywam
reviewed
Jul 26, 2023
nazywam
approved these changes
Jul 26, 2023
Co-authored-by: Michał Praszmo <michalpr@cert.pl>
psrok1
force-pushed
the
refactor/malduck-extractor
branch
from
1a8482b
to
ed8c86f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overridesand ensured that they're handled correctly. It's rarely used feature even in CERT.pl, but I don't really want to drop it.yaravinstead ofyarapthat was further remapped usingp2v. Everything worked when initial imgbase=p=0, so it wasn't visible in most cases.ExtractorModulesand configuration utilities are in separate modulesProcmemExtractManageris renamed toExtractionContextpush_procmeminto separate functions