Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show number of total indexed files in the Status page #19

Closed
ITAYC0HEN opened this issue Apr 3, 2020 · 4 comments · Fixed by #91
Closed

Show number of total indexed files in the Status page #19

ITAYC0HEN opened this issue Apr 3, 2020 · 4 comments · Fixed by #91
Labels
good first issue Good for newcomers up for grabs This issue is a good candidate for PR
Milestone

Comments

@ITAYC0HEN
Copy link
Collaborator

Description
The /status page is used to provide information about the underlying infrastructure, including versions, topology, and current connections.
If a user wants to know how many files are indexed, there's no clear way to do so (unless ursadb-cli provides it somehow, and still - it is no accessible).

My suggestion is to display the number of indexed files in the dataset(s). It will also be nice-to-have to show the number of files that aren't indexed because ls /mnt/samples | wc -l != num_of_indexex_files.

A bonus feature would be to show a total size of the dataset.

@icedevml
Copy link
Contributor

icedevml commented Apr 3, 2020

@ITAYC0HEN Hello. Thanks for your input, we will look at all of these tickets soon.

If you have some spare time, then pull requests are also welcome :)

@ITAYC0HEN
Copy link
Collaborator Author

ITAYC0HEN commented Apr 3, 2020

@icedevml thank you for the great work! most of the issues/feature-requests are already informed and synced to @msm-code on our chats, so I hope I didn't caught you in too big of a shock 😅.

Moreover, the most important and interesting features were not submitted yet, and I'll fill them tomorrow :)

@ITAYC0HEN
Copy link
Collaborator Author

ITAYC0HEN commented Apr 3, 2020

And of course, pull requests will be submitted! 😉
I need to get a better grip in the codebase first

@msm-code msm-code added good first issue Good for newcomers javascript up for grabs This issue is a good candidate for PR labels Apr 4, 2020
@msm-code
Copy link
Contributor

msm-code commented Apr 4, 2020

Thanks for your help again!

It will also be nice-to-have to show the number of files that aren't indexed because ls /mnt/samples | wc -l != num_of_indexex_files.

That's harder to implement than it looks like. (To avoid technical details, ursadb only knows about indexed samples and also there's nothing stopping you from indexing files in various directories).

OTOH this sounds like a valid use case for most common deploymen. If you don't mind, I've created a separate issue for it (#42)

@msm-code msm-code added this to the v1.1.0 milestone Apr 8, 2020
JaroPowerH added a commit to JaroPowerH/mquery that referenced this issue Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers up for grabs This issue is a good candidate for PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants