Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#19 my first easy task in mquery #91

Merged
merged 1 commit into from Apr 14, 2020

Conversation

JaroPowerH
Copy link
Contributor

@JaroPowerH JaroPowerH commented Apr 13, 2020

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running mquery, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

What is the new behaviour?

Test plan

Closing issues

fixes #19

@msm-code
Copy link
Contributor

Looks good!

ss

Though not sure about adding a new column - maybe display it in the size column instead?

I.e. something like 2.89 GiB (50001 files).

Thoughts?

@JaroPowerH
Copy link
Contributor Author

JaroPowerH commented Apr 14, 2020 via email

@ITAYC0HEN
Copy link
Collaborator

ITAYC0HEN commented Apr 14, 2020

Thank you!
So I played with it a bit. I can't tell for sure what data the team prioritizes to show the user at first sight, but this can be a clean solution.

So, what do you think about something like this?

mquery_show_topology_collapse2

@msm-code
Copy link
Contributor

Ok, maybe first we'll merge the solution from @JaroPowerH and work on the more advanced version that you've shown later.

@msm-code msm-code merged commit 670bb48 into CERT-Polska:master Apr 14, 2020
@JaroPowerH
Copy link
Contributor Author

I will be pleased to work on the solution proposed by ITAYC0HEN.

@JaroPowerH JaroPowerH deleted the feature/#19 branch April 14, 2020 11:30
@msm-code
Copy link
Contributor

msm-code commented Apr 14, 2020

@ITAYC0HEN mentioned that he has some code already, so maybe we can leave this to him.

Maybe try #94 or #35?

KWMORALE pushed a commit to KWMORALE/mquery that referenced this pull request Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show number of total indexed files in the Status page
3 participants