Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in user.py #561

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Fix regression in user.py #561

merged 2 commits into from
Mar 16, 2022

Conversation

dd8917vk
Copy link
Contributor

When implementing email sign up and verification for the project, We will get an error if this decode method is not removed on line 141:

mwdb_1 | [ERROR] uWSGIWorker4Core0 - service.error_router:76 - Unhandled exception occurred
mwdb_1 | Traceback (most recent call last):
mwdb_1 | File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1516, in full_dispatch_request
mwdb_1 | rv = self.dispatch_request()
mwdb_1 | File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1502, in dispatch_request
mwdb_1 | return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
mwdb_1 | File "/usr/local/lib/python3.8/site-packages/flask_restful/init.py", line 467, in wrapper
mwdb_1 | resp = resource(*args, **kwargs)
mwdb_1 | File "/usr/local/lib/python3.8/site-packages/flask_limiter/extension.py", line 1036, in __inner
mwdb_1 | return current_app.ensure_sync(obj)(*a, **k)
mwdb_1 | File "/usr/local/lib/python3.8/site-packages/flask_limiter/extension.py", line 1036, in __inner
mwdb_1 | return current_app.ensure_sync(obj)(*a, **k)
mwdb_1 | File "/usr/local/lib/python3.8/site-packages/flask_limiter/extension.py", line 1036, in __inner
mwdb_1 | return current_app.ensure_sync(obj)(*a, **k)
mwdb_1 | [Previous line repeated 5 more times]
mwdb_1 | File "/usr/local/lib/python3.8/site-packages/flask/views.py", line 84, in view
mwdb_1 | return current_app.ensure_sync(self.dispatch_request)(*args, **kwargs)
mwdb_1 | File "/usr/local/lib/python3.8/site-packages/flask_restful/init.py", line 582, in dispatch_request
mwdb_1 | resp = meth(*args, **kwargs)
mwdb_1 | File "/app/./mwdb/resources/init.py", line 31, in endpoint
mwdb_1 | return f(*args, **kwargs)
mwdb_1 | File "/app/./mwdb/resources/user.py", line 140, in post
mwdb_1 | set_password_token=user.generate_set_password_token().decode("utf-8"),
mwdb_1 | AttributeError: 'str' object has no attribute 'decode'

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

What is the new behaviour?

Test plan

Closing issues

closes #issuenumber

When implementing email sign up and verification for the project, We will get an error if this decode method is not removed on line 141:

mwdb_1                  | [ERROR] uWSGIWorker4Core0 - service.error_router:76 - Unhandled exception occurred
mwdb_1                  | Traceback (most recent call last):
mwdb_1                  |   File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1516, in full_dispatch_request
mwdb_1                  |     rv = self.dispatch_request()
mwdb_1                  |   File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1502, in dispatch_request
mwdb_1                  |     return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
mwdb_1                  |   File "/usr/local/lib/python3.8/site-packages/flask_restful/__init__.py", line 467, in wrapper
mwdb_1                  |     resp = resource(*args, **kwargs)
mwdb_1                  |   File "/usr/local/lib/python3.8/site-packages/flask_limiter/extension.py", line 1036, in __inner
mwdb_1                  |     return current_app.ensure_sync(obj)(*a, **k)
mwdb_1                  |   File "/usr/local/lib/python3.8/site-packages/flask_limiter/extension.py", line 1036, in __inner
mwdb_1                  |     return current_app.ensure_sync(obj)(*a, **k)
mwdb_1                  |   File "/usr/local/lib/python3.8/site-packages/flask_limiter/extension.py", line 1036, in __inner
mwdb_1                  |     return current_app.ensure_sync(obj)(*a, **k)
mwdb_1                  |   [Previous line repeated 5 more times]
mwdb_1                  |   File "/usr/local/lib/python3.8/site-packages/flask/views.py", line 84, in view
mwdb_1                  |     return current_app.ensure_sync(self.dispatch_request)(*args, **kwargs)
mwdb_1                  |   File "/usr/local/lib/python3.8/site-packages/flask_restful/__init__.py", line 582, in dispatch_request
mwdb_1                  |     resp = meth(*args, **kwargs)
mwdb_1                  |   File "/app/./mwdb/resources/__init__.py", line 31, in endpoint
mwdb_1                  |     return f(*args, **kwargs)
mwdb_1                  |   File "/app/./mwdb/resources/user.py", line 140, in post
mwdb_1                  |     set_password_token=user.generate_set_password_token().decode("utf-8"),
mwdb_1                  | AttributeError: 'str' object has no attribute 'decode'
@psrok1
Copy link
Member

psrok1 commented Mar 16, 2022

Oops, that looks to be regression introduced by #542. Thanks for fix! ❤️

@psrok1 psrok1 changed the title Update user.py Fix regression in user.py Mar 16, 2022
@psrok1 psrok1 merged commit f8999a8 into CERT-Polska:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants