Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/e2e with karton services #572

Merged
merged 16 commits into from
Apr 5, 2022
Merged

Conversation

wklimek
Copy link
Contributor

@wklimek wklimek commented Mar 28, 2022

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

Built-in Karton integration is not covered by automated tests.
What is the new behaviour?

Built-in Karton integration is covered by e2e automated tests.

Closing issues

closes #445

@wklimek wklimek requested a review from psrok1 March 28, 2022 13:23
@wklimek wklimek marked this pull request as ready for review March 28, 2022 13:59
@psrok1 psrok1 force-pushed the feature/e2e-with-karton-services branch from 4b13a78 to 4dd850a Compare April 5, 2022 12:18
@psrok1 psrok1 merged commit a01832a into master Apr 5, 2022
@psrok1 psrok1 deleted the feature/e2e-with-karton-services branch April 5, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests: Add basic Karton services to E2E tests
2 participants