-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Lo-Cal Localization Nation #17
Conversation
This man has the most professional background out of all of us, I'm in awe of his talent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need some nice way to automatically translate item displaynames, not entirely sure how that would look though
Since the config is exposed to the end user, should we validate the language they input? The errors will likely be pretty confusing if they enter a language we don't support. We can put something meaningful in console and fallback to english |
Wow peri just pushing to my pr instead of making comments 😒 |
Teamwork! |
L.commandsInConsole = { | ||
en = "Look in console for a list of commands.", | ||
fr = "<UNKNOWN>" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline at the end pls
} | |
} | |
TODO:
Notes
This is mostly a framework for localization. It allows individual word translations, and long sentences with formatting, so it pretty much covers all of the bases. There's an example for all use cases in the changes.
Down the line we may want to look into allowing clients to set their own language, but that'll get kind of complicated. I'm thinking that the server should set the global language, as it's likely rare that someone who's unable to speak the server's language will still play on that server (read: more issues arise from not speaking the language than not understanding the gamemode)
I left the commands alone, it'll be a bit of a hassle to change the commands based on language and I imagine some grammatical issues could pop up, too, but I'm happy to add it if you think it's necessary.