Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Lo-Cal Localization Nation #17

Closed
wants to merge 7 commits into from

Conversation

brandonsturgeon
Copy link
Member

@brandonsturgeon brandonsturgeon commented Jul 4, 2020

TODO:

  • Test

Notes

This is mostly a framework for localization. It allows individual word translations, and long sentences with formatting, so it pretty much covers all of the bases. There's an example for all use cases in the changes.

Down the line we may want to look into allowing clients to set their own language, but that'll get kind of complicated. I'm thinking that the server should set the global language, as it's likely rare that someone who's unable to speak the server's language will still play on that server (read: more issues arise from not speaking the language than not understanding the gamemode)

I left the commands alone, it'll be a bit of a hassle to change the commands based on language and I imagine some grammatical issues could pop up, too, but I'm happy to add it if you think it's necessary.

@brandonsturgeon brandonsturgeon changed the title L O C A L The Lo-Cal Localization Nation Jul 4, 2020
@samuelWilliams99
Copy link
Member

This man has the most professional background out of all of us, I'm in awe of his talent

Copy link
Member

@samuelWilliams99 samuelWilliams99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need some nice way to automatically translate item displaynames, not entirely sure how that would look though

gamemode/localization.lua Show resolved Hide resolved
@samuelWilliams99
Copy link
Member

samuelWilliams99 commented Jul 5, 2020

Since the config is exposed to the end user, should we validate the language they input? The errors will likely be pretty confusing if they enter a language we don't support. We can put something meaningful in console and fallback to english

@brandonsturgeon
Copy link
Member Author

Wow peri just pushing to my pr instead of making comments 😒

@samuelWilliams99
Copy link
Member

Teamwork!

@plally plally self-requested a review July 9, 2020 17:11
@brandonsturgeon brandonsturgeon self-assigned this Jul 13, 2020
@brandonsturgeon brandonsturgeon added the feature New feature or request label Jul 13, 2020
L.commandsInConsole = {
en = "Look in console for a list of commands.",
fr = "<UNKNOWN>"
}
Copy link
Contributor

@loganlearner loganlearner Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline at the end pls

Suggested change
}
}

gamemode/shared.lua Show resolved Hide resolved
gamemode/shared.lua Show resolved Hide resolved
@brandonsturgeon brandonsturgeon deleted the feature/add-localization branch August 19, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants